-
-
Notifications
You must be signed in to change notification settings - Fork 179
chore(package): update uglify-es
v3.2.0...v3.2.1
#190
chore(package): update uglify-es
v3.2.0...v3.2.1
#190
Conversation
@SuperManEver Why? Seems you have outdated npm cache. Just run |
@evilebottnawi tried this several times. Locally it works perfect, no errors appear, but when I try to upload my code to heroku error arises. I tried with version 3.2.0 and I get exactly the same error I get when heroku tries to build my bundle. If I use uglify-es version 3.2.1, everything works fine |
@SuperManEver what is error you get? This #187 (comment)? |
@evilebottnawi this one |
@evilebottnawi the fastest way how you can convince yourself that problem in 'uglify-es' version is by taking this file https://github.com/izolate/millify/blob/master/index.js and try to minify it with |
@SuperManEver confirm, please update snapshots |
That's not the case. Updating the
|
uglify-es
v3.2.0...v3.2.1
@evilebottnawi not exactly understand what should I do about this "please update snapshots npm run test -- -u". Can you explain it a little bit more, please? |
I wonder where this change to the test snapshot is coming from tbh |
@SuperManEver run |
@evilebottnawi updated snapshot by running |
related to this issue: #187
uglify-es version 3.2.0 doesn't support
const
and arrow-function. In my case, this causes build failure when I try to make a production bundle for deployment