fix(uglify/worker): better {Error} handling

[alexander-akait]

No description provided.

[michael-ciniawsky]

Could you please show a screenshot of the output ? Nice if it already works with this elegant change :)

[michael-ciniawsky]

Also the {Error} shape/type of the err before pushing to compilation.errors needs to be checked :)

[alexander-akait]

@michael-ciniawsky what do you mean? 😄

[michael-ciniawsky]

A screenshot/logs of the {Error} and what does the worker return as err {String|Object} {Object} === instanceof Error (when it is passed to compilation.errors.push(err)) ? 🙃

[michael-ciniawsky]

Could we clearify if this definitely fixes the {Error} handling and get this PR and #243 out asap ? :)

[alexander-akait]

@michael-ciniawsky 👍

[alexander-akait]

@michael-ciniawsky this solution don't works because we can't build UglifyJsPlugin.buildError (for right source map position and other meta information) we should serialize error for right handle 😞 It is only right way here

[michael-ciniawsky]

Can you explain this a bit more detailed please :) ? The buildUglifyError could maybe made it's own{Error} Class instead, which handles the serialized error {String|Object}

Uglify[Worker]Error.js

class Uglify[Worker]Error extends Error {
   constructor (serialized) {
      const err = JSON.parse(serialized)
       
      this.name = err.name
      this.message = `\n\n(${err.line}:${err.column}) ${err.message}...\n`
      
      Error.captureStackTrace(this, this.constructor)
   }
}

module.exports = Uglify[Worker]Error

[joshwiens]

Please rebase with current master

[michael-ciniawsky]

@evilebottnawi Status? :)

[alexander-akait]

@michael-ciniawsky apparently something was wrongly installed or configured, the problem is no longer there