This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix: don't handle invalid source map #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
fix-invalid-source-map-property
branch
from
fdd450c
to
f9d8901
Compare
|
Please rebase with current master |
joshwiens
force-pushed
the
fix-invalid-source-map-property
branch
from
f9d8901
to
cede5dc
Compare
alexander-akait
force-pushed
the
fix-invalid-source-map-property
branch
from
cede5dc
to
d26c2ad
Compare
|
@d3viant0ne done, something wrong with ci on node6 😕 |
alexander-akait
force-pushed
the
fix-invalid-source-map-property
branch
from
d26c2ad
to
715f0cb
Compare
alexander-akait
force-pushed
the
fix-invalid-source-map-property
branch
from
715f0cb
to
e8990e1
Compare
alexander-akait
commented
Apr 10, 2018
| inputSourceMap = map; | ||
| sourceMap = null; | ||
|
|
||
| compilation.warnings.push( |
There was a problem hiding this comment.
Throw warning on invalid source map. Is it very DX.
alexander-akait
commented
Apr 10, 2018
| @@ -78,7 +78,7 @@ describe('when options.parallel', () => { | |||
| beforeEach(() => { | |||
| chunkPluginEnvironment = new PluginEnvironment(); | |||
| compilation = chunkPluginEnvironment.getEnvironmentStub(); | |||
| compilation.assets = assets; | |||
| compilation.assets = Object.assign({}, assets); | |||
There was a problem hiding this comment.
Compilation mondify assets, we should clone assets
whtsky
pushed a commit
to whtsky/uglifyjs-3-webpack-plugin
that referenced
this pull request
Apr 16, 2018
whtsky
pushed a commit
to whtsky/uglifyjs-3-webpack-plugin
that referenced
this pull request
Apr 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #261
Also refactor tests