-
-
Notifications
You must be signed in to change notification settings - Fork 179
ci(Travis): Enable OSX build on current master #67
Conversation
@d3viant0ne Sure, I will have a look. @hulkish put them in place, maybe he would be more relevant (basically I am a newbie considering unit testing, but will try my best). |
//cc @hulkish |
ah... i wonder if this has to do with the error stack containing backslashes on windows in the snapshot? ill take a look. |
@hulkish - It's not a windows issue, that fails on OSX as well ( Note the expected vs. received ). It failing on OSX is how I found it in the first place ( I run tests before I do a release ). It's kind of random which is why I used the work flakey. |
@d3viant0ne hmm...im having a hard time replicating this behavior - I'm on macOS. Can you confirm you don't have any npm/yarn links that might be interfering? And, I guess ultimately make sure it's using correct version of |
@d3viant0ne I tried to reproduce on Windows 10, both on git bash and cmd, I could not manage it, all the tests went green. |
Should this land or better enable macOS builds in gerenal via |
@michael-ciniawsky - OSX builds block executions of any other build on Travis, thus we avoid it. This really isn't an OSX issue, it was just the easiest way to highlight the issue with the test. This pull request should be closed when no longer needed. |
@d3viant0ne I think we're past this issue now, right? Can be closed? |
Don't Merge This, example for test timing issues currently in master
@Hartorn - If you don't mind, can you fix the es2015 test? There is a timing issue ( it's flakey ).