Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

ci(Travis): Enable OSX build on current master #67

Closed
wants to merge 3 commits into from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Jul 6, 2017

Don't Merge This, example for test timing issues currently in master

@Hartorn - If you don't mind, can you fix the es2015 test? There is a timing issue ( it's flakey ).

  • The assertion fails randomly on Windows & OSX, see the build output of the second & third commit in this PR.

@Hartorn
Copy link
Contributor

Hartorn commented Jul 6, 2017

@d3viant0ne Sure, I will have a look. @hulkish put them in place, maybe he would be more relevant (basically I am a newbie considering unit testing, but will try my best).

@joshwiens
Copy link
Member Author

//cc @hulkish

@hulkish
Copy link
Contributor

hulkish commented Jul 6, 2017

ah... i wonder if this has to do with the error stack containing backslashes on windows in the snapshot? ill take a look.

@joshwiens
Copy link
Member Author

joshwiens commented Jul 6, 2017

@hulkish - It's not a windows issue, that fails on OSX as well ( Note the expected vs. received ). It failing on OSX is how I found it in the first place ( I run tests before I do a release ).

It's kind of random which is why I used the work flakey.

screen_shot_2017-07-05_at_9 03 38_pm

@hulkish
Copy link
Contributor

hulkish commented Jul 6, 2017

@d3viant0ne hmm...im having a hard time replicating this behavior - I'm on macOS. Can you confirm you don't have any npm/yarn links that might be interfering?

And, I guess ultimately make sure it's using correct version of uglify-es.

@Hartorn
Copy link
Contributor

Hartorn commented Jul 6, 2017

@d3viant0ne I tried to reproduce on Windows 10, both on git bash and cmd, I could not manage it, all the tests went green.
I will try some more this week-end, both on Linux Mint and Windows.

@michael-ciniawsky
Copy link
Member

Should this land or better enable macOS builds in gerenal via webpack-defaults ?

@joshwiens
Copy link
Member Author

@michael-ciniawsky - OSX builds block executions of any other build on Travis, thus we avoid it.

This really isn't an OSX issue, it was just the easiest way to highlight the issue with the test.

This pull request should be closed when no longer needed.

@hulkish
Copy link
Contributor

hulkish commented Jul 13, 2017

@d3viant0ne I think we're past this issue now, right? Can be closed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants