test: add test for MultiCompiler usage
#74
Conversation
hulkish
force-pushed
the
hulkish-FixMultiCompiler
branch
4 times, most recently
from
fc62311 to
f9b569b
Compare
test/helpers.js
Outdated
| const eventLength = Array.isArray(_plugins[name]) ? _plugins[name].length : 0; | ||
|
|
||
| if (eventLength > currentLength) { | ||
| Object.assign(aggregate, { |
There was a problem hiding this comment.
Why not just aggregate[name] = eventLength?
| } | ||
|
|
||
| exports.removeCWD = function removeCWD(str) { | ||
| export function countPlugins({ _plugins }) { |
There was a problem hiding this comment.
What is the usecase here ? :)
There was a problem hiding this comment.
@Kovensky @michael-ciniawsky Was for the test I hadn't added at first to this pr. But, I have since added it: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/74/files#diff-0570d5214a7cbff246a7ad90d119f15c
src/index.js
Outdated
|
|
||
| apply(compiler) { | ||
| const requestShortener = new RequestShortener(compiler.context); | ||
| const requestShortener = new RequestShortener(compiler.context || process.cwd()); |
There was a problem hiding this comment.
Is process.cwd() save to use in most cases ?
There was a problem hiding this comment.
Oops, i have a regression test to add that uses this
There was a problem hiding this comment.
@michael-ciniawsky - Agree here. We should get context without using process. || window || w/e
| } | ||
|
|
||
| exports.removeCWD = function removeCWD(str) { | ||
| export function countPlugins({ _plugins }) { |
There was a problem hiding this comment.
What is the usecase here ? :)
michael-ciniawsky
changed the title
MultiCompiler support
|
path.resolve()? |
For |
hulkish
force-pushed
the
hulkish-FixMultiCompiler
branch
from
f9b569b to
351cbfa
Compare
|
@michael-ciniawsky yes, |
…ce it seems to have magically fixed itself
hulkish
force-pushed
the
hulkish-FixMultiCompiler
branch
from
264114e to
50bf746
Compare
michael-ciniawsky
changed the title
MultiCompiler supportMultiCompiler usage
Fixes #73
Update: So, it looks like this issue just magically fixed itself. That, said - I'd like to still include the added tests and upgrade to
uglify-es@3.0.24.