chore!: minimum supported Node.js version is 18.12.0 (#151)

webpack-contrib · Jan 15, 2024 · ed762dc · ed762dc
1 parent 59a7497
commit ed762dc
Show file tree

Hide file tree

Showing 11 changed files with 7,757 additions and 16,699 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -60,7 +60,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        node-version: [14.x, 16.x, 18.x, 20.x]
+        node-version: [18.x, 20.x, 21.x]
         webpack-version: [latest]
 
     runs-on: ${{ matrix.os }}

diff --git a/README.md b/README.md
@@ -131,7 +131,7 @@ module.exports = {
               executableFile: path.resolve(
                 __dirname,
                 "fixtures",
-                "executableFile.js"
+                "executableFile.js",
               ),
             },
           },

diff --git a/babel.config.js b/babel.config.js
@@ -10,7 +10,7 @@ module.exports = (api) => {
         "@babel/preset-env",
         {
           targets: {
-            node: "14.15.0",
+            node: "18.12.0",
           },
         },
       ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
   },
   "main": "dist/cjs.js",
   "engines": {
-    "node": ">= 14.15.0"
+    "node": ">= 18.12.0"
   },
   "scripts": {
     "start": "npm run build -- -w",
@@ -24,7 +24,7 @@
     "security": "npm audit --production",
     "lint:prettier": "prettier --list-different .",
     "lint:js": "eslint --cache .",
-    "lint:spelling": "cspell \"**/*.*\"",
+    "lint:spelling": "cspell --no-must-find-files --cache --quiet \"**/*.*\"",
     "lint": "npm-run-all -l -p \"lint:**\"",
     "fix:js": "npm run lint:js -- --fix",
     "fix:prettier": "npm run lint:prettier -- --write",
@@ -46,26 +46,26 @@
   "devDependencies": {
     "@babel/cli": "^7.23.4",
     "@babel/core": "^7.23.7",
-    "@babel/preset-env": "^7.23.7",
-    "@commitlint/cli": "^17.7.2",
-    "@commitlint/config-conventional": "^17.7.0",
+    "@babel/preset-env": "^7.23.8",
+    "@commitlint/cli": "^18.4.4",
+    "@commitlint/config-conventional": "^18.4.4",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "cross-env": "^7.0.3",
-    "cspell": "^6.31.2",
-    "del": "^6.1.1",
-    "del-cli": "^4.0.1",
+    "cspell": "^8.3.2",
+    "del": "^7.1.0",
+    "del-cli": "^5.1.0",
     "eslint": "^8.56.0",
-    "eslint-config-prettier": "^8.9.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
     "figlet": "^1.7.0",
     "husky": "^8.0.3",
     "jest": "^29.7.0",
-    "lint-staged": "^13.2.3",
-    "memfs": "^3.5.1",
+    "lint-staged": "^15.2.0",
+    "memfs": "^4.6.0",
     "modernizr": "^3.13.0",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.8.8",
-    "standard-version": "^9.3.2",
+    "prettier": "^3.2.2",
+    "standard-version": "^9.5.0",
     "webpack": "^5.89.0"
   },
   "keywords": [

diff --git a/src/index.js b/src/index.js
@@ -23,8 +23,8 @@ function processResult(loaderContext, result) {
   if (!result || typeof result !== "object" || "code" in result === false) {
     loaderContext.callback(
       new Error(
-        `The returned result of module "${loaderContext.resource}" is not an object with a "code" property`
-      )
+        `The returned result of module "${loaderContext.resource}" is not an object with a "code" property`,
+      ),
     );
 
     return;
@@ -36,23 +36,23 @@ function processResult(loaderContext, result) {
   ) {
     loaderContext.callback(
       new Error(
-        `The returned code of module "${loaderContext.resource}" is neither a string nor an instance of Buffer`
-      )
+        `The returned code of module "${loaderContext.resource}" is neither a string nor an instance of Buffer`,
+      ),
     );
 
     return;
   }
 
   (result.dependencies || []).forEach((dep) =>
-    loaderContext.addDependency(dep)
+    loaderContext.addDependency(dep),
   );
 
   (result.contextDependencies || []).forEach((dep) =>
-    loaderContext.addContextDependency(dep)
+    loaderContext.addContextDependency(dep),
   );
 
   (result.buildDependencies || []).forEach((dep) =>
-    loaderContext.addBuildDependency(dep)
+    loaderContext.addBuildDependency(dep),
   );
 
   // Defaults to false which is a good default here because we assume that
@@ -63,7 +63,7 @@ function processResult(loaderContext, result) {
     null,
     result.code,
     result.sourceMap || null,
-    result.ast || null
+    result.ast || null,
   );
 }
 
@@ -121,8 +121,8 @@ export default async function loader(content) {
   if (typeof func !== "function") {
     callback(
       new Error(
-        `Module "${this.resource}" does not export a function as default`
-      )
+        `Module "${this.resource}" does not export a function as default`,
+      ),
     );
     return;
   }

diff --git a/test/executableFile.test.js b/test/executableFile.test.js
@@ -22,7 +22,7 @@ describe("executableFile option", () => {
                     executableFile: path.resolve(
                       __dirname,
                       "fixtures",
-                      "executableFile.js"
+                      "executableFile.js",
                     ),
                   },
                 },
@@ -34,15 +34,15 @@ describe("executableFile option", () => {
             },
           ],
         },
-      }
+      },
     );
     const stats = await compile(compiler);
 
     expect(readAsset("val-loader.js", compiler, stats)).toMatchSnapshot(
-      "result"
+      "result",
     );
     expect(normalizeErrors(stats.compilation.warnings)).toMatchSnapshot(
-      "warnings"
+      "warnings",
     );
     expect(normalizeErrors(stats.compilation.errors)).toMatchSnapshot("errors");
   });
@@ -67,7 +67,7 @@ describe("executableFile option", () => {
                     executableFile: path.resolve(
                       __dirname,
                       "fixtures",
-                      "executableFileES.mjs"
+                      "executableFileES.mjs",
                     ),
                   },
                 },
@@ -79,15 +79,15 @@ describe("executableFile option", () => {
             },
           ],
         },
-      }
+      },
     );
     const stats = await compile(compiler);
 
     expect(readAsset("val-loader.js", compiler, stats)).toMatchSnapshot(
-      "result"
+      "result",
     );
     expect(normalizeErrors(stats.compilation.warnings)).toMatchSnapshot(
-      "warnings"
+      "warnings",
     );
     expect(normalizeErrors(stats.compilation.errors)).toMatchSnapshot("errors");
   });
@@ -111,7 +111,7 @@ describe("executableFile option", () => {
                     executableFile: path.resolve(
                       __dirname,
                       "fixtures",
-                      "error-require.js"
+                      "error-require.js",
                     ),
                   },
                 },
@@ -123,12 +123,12 @@ describe("executableFile option", () => {
             },
           ],
         },
-      }
+      },
     );
     const stats = await compile(compiler);
 
     expect(normalizeErrors(stats.compilation.warnings)).toMatchSnapshot(
-      "warnings"
+      "warnings",
     );
     expect(normalizeErrors(stats.compilation.errors)).toMatchSnapshot("errors");
   });

diff --git a/test/helpers/execute.js b/test/helpers/execute.js
@@ -8,14 +8,14 @@ export default (code) => {
   const module = new Module(resource, parentModule);
   // eslint-disable-next-line no-underscore-dangle
   module.paths = Module._nodeModulePaths(
-    path.resolve(__dirname, "../fixtures")
+    path.resolve(__dirname, "../fixtures"),
   );
   module.filename = resource;
 
   // eslint-disable-next-line no-underscore-dangle
   module._compile(
     `let __export__;${code};module.exports = __export__;`,
-    resource
+    resource,
   );
 
   return module.exports;

diff --git a/test/helpers/helperLoader.js b/test/helpers/helperLoader.js
@@ -6,14 +6,14 @@ function rel(p) {
 
 export default function helperLoader(content, map, meta) {
   const dependencies = this.getDependencies().map((dependency) =>
-    rel(dependency).replace(/\\/g, "/")
+    rel(dependency).replace(/\\/g, "/"),
   );
   const contextDependencies = this.getContextDependencies().map((dependency) =>
-    rel(dependency).replace(/\\/g, "/")
+    rel(dependency).replace(/\\/g, "/"),
   );
 
   const buildDependencies = Array.from(
-    this._module.buildInfo.buildDependencies || []
+    this._module.buildInfo.buildDependencies || [],
   ).map((dependency) => rel(dependency).replace(/\\/g, "/"));
   const json = JSON.stringify(
     {
@@ -25,7 +25,7 @@ export default function helperLoader(content, map, meta) {
       buildDependencies,
     },
     null,
-    "  "
+    "  ",
   )
     .replace(/\u2028/g, "\\u2028")
     .replace(/\u2029/g, "\\u2029");

diff --git a/test/helpers/normalizeErrors.js b/test/helpers/normalizeErrors.js
@@ -14,11 +14,11 @@ function removeCWD(str) {
     .replace(new RegExp(cwd, "g"), "")
     .replace(
       /Cannot read property 'get' of undefined/,
-      "Cannot read properties of undefined (reading 'get')"
+      "Cannot read properties of undefined (reading 'get')",
     );
 }
 
 export default (errors) =>
   errors.map((error) =>
-    removeCWD(error.toString().split("\n").slice(0, 2).join("\n"))
+    removeCWD(error.toString().split("\n").slice(0, 2).join("\n")),
   );