Switch lerna and yarn to use workspaces #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron@1.8.0 has been yanked and trying to install it will fail. There hasn't yet been a new release of nightmare that pins the electron to 1.7.x release, so I'll have to point to a commit directly.
This is the major win in using yarn workspaces to manage the monorepo. We'll only have one yarn.lock file now, whee!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #97
https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/
The best thing is that we'll now only have one
yarn.lockfile in the root.Note that to get this working, I had to manually pin
nightmaredev-dependency to a git commit, as the sub-depelectron@1.8.0has been yanked and yarn wanted to install that — and failing. In particular, this incorporates segment-boneyard/nightmare#1270 which fixes segment-boneyard/nightmare#1269