Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ESLint configs #148

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Simplify ESLint configs #148

merged 1 commit into from
Feb 1, 2018

Conversation

th0r
Copy link
Collaborator

@th0r th0r commented Feb 1, 2018

Use my configs and extend from them.

alexander-akait
alexander-akait reviewed Feb 1, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about migrate on webpack-default, we use this for all repos.

@th0r
Copy link
Collaborator Author

th0r commented Feb 1, 2018

I don't mind. The only concern I have is @valscion's v3 branch - it will be very difficult for him to merge it if migration will require a lot of changes.

@alexander-akait
Copy link
Member

@th0r i think better release v3 and when migrate 👍

@th0r
Copy link
Collaborator Author

th0r commented Feb 1, 2018

Agree!

@th0r th0r merged commit 8d152b5 into master Feb 1, 2018
@th0r th0r deleted the update-eslint-configs branch February 1, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th0r @alexander-akait