Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overwriting of bundleDir via bundleDirOption from plugin option. #276

Closed
wants to merge 6 commits into from
Closed

Allow overwriting of bundleDir via bundleDirOption from plugin option. #276

wants to merge 6 commits into from

Conversation

amoshydra
Copy link
Contributor

Details

  • Allow overwriting of bundleDir via bundleDirOption from plugin option.
  • Updated documentation for bundleDirOption
  • Added 3 tests for bundleDirOption
  Plugin
    options
      bundleDirOption
        √ should report parsedSize and gzipSize when bundleDirOption is not provided (269ms)
        √ should report parsedSize and gzipSize when bundleDirOption is null (264ms)
        √ should report statSize only bundleDirOption is false (270ms)

Related issues

@jsf-clabot
Copy link

jsf-clabot commented Apr 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@amoshydra amoshydra mentioned this pull request Apr 25, 2019
Closed
@th0r
Copy link
Collaborator

th0r commented May 8, 2019

#274 is fixed by #275

@th0r th0r closed this May 8, 2019
@amoshydra amoshydra deleted the feature/configurable-build-dir branch May 9, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amoshydra @jsf-clabot @th0r