Replace mkdirp with builtin recursive flag #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In node 10.12 mkdir got new recursive flag which provides the same functionality as mkdirp. See here https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback Also node 10 got builtin promisified `fs` utilities. See here https://nodejs.org/api/fs.html#fs_fs_promises_api
th0r
requested changes
Nov 6, 2020
th0r
requested changes
Nov 6, 2020
th0r
approved these changes
Nov 6, 2020
|
|
|
Thanks! |
Closing and reopening the pull request triggers a new |
|
I just do empty commits in such cases |
|
Released in v4.2.0 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node 10.12 mkdir got new recursive flag which provides the same
functionality as mkdirp.
See here https://nodejs.org/api/fs.html#fs_fs_mkdir_path_options_callback
Also node 10 got builtin promisified
fsutilities.See here https://nodejs.org/api/fs.html#fs_fs_promises_api