fix(socket-server): send stats to new connections

[ryanclark]

This sends the compilation stats directly to new connections, instead of broadcasting them globally when there is only one client connected. This fixes the issue where pages would not hot reload until a file was saved twice, as it ensures every new client receives the "initial" ok event. Should fix #92 and #93.

This worked fine with 3.0.0 because of a bug - it used to check connections.length, but because it's a Set, this was always undefined, meaning the check always passed.

By broadcasting to new connections only, this should fix #61 (as the parent window will not receive an ok event when the child connects, forcing the page to refresh). In turn, it addresses the concerns that #96 was made to fix.

Update:

I've created a bare bones setup based off of #61 and tested it on these changes. No page refreshing and both the parent window and iframe reload correctly when their respective entry files are changed.

Type

• Fix

Issues

• Fixes Browser keeps refreshing with multiple entry points/configurations #61
• Fixes reload is broken #92
• Fixes hot doesn't work when you have two or more websocket clients #93
• Fixes revert(#77): incorrect check for existing socket clients #96

SemVer

• Patch

[ryanclark]

Also, if we remove these lines of code -

webpack-hot-client/lib/client/index.js

Lines 7 to 9 in 276d950

	if (window.__webpackHotClient__) {
	return;
	}

This will also fix #95 - thoughts on including that?

I've ran a test against the code in #61 as well as the same code but without the iframe (both entries in index.html) and removing that line as well as the changes in this PR gives us the expected correct behaviour.

[michael-ciniawsky]

@rynclark Would you like to include the fix mentioned in #102 (comment) in this PR or open or would you like to open a separate PR for it as a follow up?

[rudi23]

@michael-ciniawsky could you merge it, please? :)

[ryanclark]

webpack-serve has been deprecated and as far as I'm aware, the author also has exclusive publish rights to this package on npm, effectively making webpack-hot-client useless from this point onwards

[rudi23]

Thanks for the info 👍 it's new for me that webpack-serve has been deprecated

[ryanelian]

webpack-serve has been deprecated and as far as I'm aware, the author also has exclusive publish rights to this package on npm, effectively making webpack-hot-client useless from this point onwards

Ouch. Please merge the fix and republish under new name? :)

(https://www.npmjs.com/package/webpack-hot is available)

I'd hate to see this amazing package go away.

[JasonBoy]

so when this will be merged?

[hedgepigdaniel]

I've forked this repository at https://github.com/hedgepigdaniel/webpack-hmr-client and merged this, along with some other fixes.

Its available on NPM as webpack-hmr-client