Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Make webpack-cli a devDependency rather than a dependency? #29

Closed
1 of 3 tasks
billyjanitsch opened this issue Mar 1, 2018 · 2 comments
Closed
1 of 3 tasks

Make webpack-cli a devDependency rather than a dependency? #29

billyjanitsch opened this issue Mar 1, 2018 · 2 comments

Comments

@billyjanitsch
Copy link
Contributor

  • Operating System: macOS 10.13.3
  • Node Version: 8.9.4
  • NPM Version: 5.7.1
  • webpack Version: 4.0.1
  • webpack-serve Version: 0.1.5

This issue is for a:

  • bug
  • feature request
  • modification request

Actual Behavior

Installing webpack-serve also installs webpack-cli. There don't appear to be any references to webpack-cli in webpack-serve, so I'm wondering if it needs to be included as a dependency. Maybe there's a reason for this that I'm missing?

How Do We Reproduce?

npm i webpack-serve

New Feature Use Case

webpack-cli is huge and some of its dependencies have postinstall scripts that take a ton of time, so if there's not a particular reason for webpack-serve to depend on it, it would be great to remove it from the dependencies. (Happy to PR this if you'd like.)

@shellscape
Copy link
Contributor

Good call, and thanks for the PR 🍺

At a point we were using one of it's convenience methods, but that was a while back. Looks like it stuck around as an old artifact. I'll get that cleaned up in a commit soon here.

@billyjanitsch
Copy link
Contributor Author

Cheers. Looks like there's also an unnecessary dependency on webpack-hot-client. koa-webpack needs it, but already depends on it directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants