Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

fix: handle exit on windows, closing cmd window #110

Merged
merged 1 commit into from
May 1, 2018

Conversation

shellscape
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

On windows users are prone to closing the CMD Window that serve is running in. That causes the processes to continue, resulting an in EACCESS port in use error the next time serve is run.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #110 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   92.43%   92.56%   +0.12%     
==========================================
  Files           7        7              
  Lines         291      296       +5     
==========================================
+ Hits          269      274       +5     
  Misses         22       22
Impacted Files Coverage Δ
index.js 96.15% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2958e8c...e190aa7. Read the comment docs.

@joshwiens joshwiens merged commit f6c7fb1 into master May 1, 2018
@joshwiens joshwiens deleted the fix/process-exit-term branch May 1, 2018 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants