Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

fix: calling middleware in add should find open ports. fixes #130 #133

Merged
merged 1 commit into from
May 11, 2018

Conversation

shellscape
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #130

Breaking Changes

None

Additional Info

Tests not updated as code paths not technically changed, only moved.

@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files           7        7           
  Lines         269      269           
=======================================
  Hits          260      260           
  Misses          9        9
Impacted Files Coverage Δ
lib/server.js 93.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cabb7f...9a9dbc3. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add test for avoid regression?

@shellscape
Copy link
Contributor Author

@evilebottnawi I couldn't come up with a good regression test for this case. More than happy to accept a PR if you have an idea for one.

@shellscape shellscape merged commit c9235b5 into master May 11, 2018
@shellscape shellscape deleted the fix/middleware-ports branch May 11, 2018 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] searching available ports doesn't work in some cases
2 participants