Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

feat: improve event parameters #136

Merged
merged 2 commits into from
May 12, 2018
Merged

feat: improve event parameters #136

merged 2 commits into from
May 12, 2018

Conversation

shellscape
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

This PR improves and refactors the parameters for emitted events. All event parameters are now a single object with named properties.

This also fixes #132 and adds options to the listening event.

Breaking Changes

Event parameter signatures have changed.

Additional Info

@codecov
Copy link

codecov bot commented May 12, 2018

Codecov Report

Merging #136 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   96.65%   96.64%   -0.02%     
==========================================
  Files           7        7              
  Lines         269      268       -1     
==========================================
- Hits          260      259       -1     
  Misses          9        9
Impacted Files Coverage Δ
lib/server.js 93.1% <100%> (ø) ⬆️
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9235b5...24c3730. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@shellscape shellscape merged commit ca1d54e into master May 12, 2018
@shellscape shellscape deleted the feat/event-params branch May 12, 2018 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: pass options in listening event
2 participants