Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Lots of misc #47

Merged
merged 7 commits into from
Mar 6, 2018
Merged

Lots of misc #47

merged 7 commits into from
Mar 6, 2018

Conversation

shellscape
Copy link
Contributor

@shellscape shellscape commented Mar 6, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

  • Fixed bug where a partial config, relying on webpack@4 defaults, would fail if entry was omiited
  • Updated the README with docs for on and add
  • Improved event bus test coverage. Now throws in invalid options instead of silently failing.
  • Fixed issue with get-port where it would sometimes return a port in use

Breaking Changes

The event bus will now throw on invalid options.

Additional Info

This will be the last maintenance PR before v0.2.0

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #47 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   91.89%   92.04%   +0.15%     
==========================================
  Files           7        7              
  Lines         259      264       +5     
==========================================
+ Hits          238      243       +5     
  Misses         21       21
Impacted Files Coverage Δ
lib/bus.js 100% <100%> (ø) ⬆️
lib/server.js 87.69% <100%> (ø) ⬆️
lib/options.js 87.01% <100%> (-0.33%) ⬇️
lib/config.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c492f55...e43c5c2. Read the comment docs.

@shellscape shellscape merged commit 3bd62dc into master Mar 6, 2018
@shellscape shellscape deleted the lots-of-misc branch March 6, 2018 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant