Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Allow Users to Completely Disable webpack-hot-client #50

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

shellscape
Copy link
Contributor

@shellscape shellscape commented Mar 7, 2018

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

There have been repeated requests to completely disable all HMR functionality for webpack-serve. While that kind of defeats the purpose of the top-to-bottom setup, it's obvious folks are using this for it's bindings to webpack-dev-middleware in lieu of HMR.

This PR introduces support for setting hot: false instead of an Object, and the --no-hot-client CLI flag. The result is that webpack-hot-client will never be instantiated through koa-webpack, no WebSocket serve will be started, and the user will be responsible for loading changes tracked by webpack.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #50 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   92.04%   92.19%   +0.14%     
==========================================
  Files           7        7              
  Lines         264      269       +5     
==========================================
+ Hits          243      248       +5     
  Misses         21       21
Impacted Files Coverage Δ
cli.js 96.77% <ø> (ø) ⬆️
lib/options.js 87.8% <100%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f4806...ed8a78b. Read the comment docs.

@shellscape shellscape merged commit a7e5114 into master Mar 9, 2018
@shellscape shellscape deleted the disable-hot-client branch March 9, 2018 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant