This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Allow Users to Completely Disable webpack-hot-client #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
There have been repeated requests to completely disable all HMR functionality for
webpack-serve
. While that kind of defeats the purpose of the top-to-bottom setup, it's obvious folks are using this for it's bindings towebpack-dev-middleware
in lieu of HMR.This PR introduces support for setting
hot: false
instead of anObject
, and the--no-hot-client
CLI flag. The result is thatwebpack-hot-client
will never be instantiated throughkoa-webpack
, noWebSocket
serve will be started, and the user will be responsible for loading changes tracked by webpack.Breaking Changes
None
Additional Info