Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

fix(cli): fixes #70. dev/hot flags should be parsed #91

Merged
merged 1 commit into from
Mar 31, 2018

Conversation

shellscape
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #70
The --dev flag was not being parsed and applied to options correctly.
The --hot flag was also missing from the CLI help and docs, and was not being parsed and applied correctly.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #91 into master will decrease coverage by 0.49%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #91     +/-   ##
=========================================
- Coverage   92.93%   92.43%   -0.5%     
=========================================
  Files           7        7             
  Lines         283      291      +8     
=========================================
+ Hits          263      269      +6     
- Misses         20       22      +2
Impacted Files Coverage Δ
cli.js 97.43% <ø> (ø) ⬆️
lib/options.js 88.54% <77.77%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a956b...7c1117e. Read the comment docs.

@joshwiens joshwiens merged commit 88907e1 into master Mar 31, 2018
@joshwiens joshwiens deleted the fix/dev-flag branch March 31, 2018 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats is ignored
2 participants