camelCase doesn't delete original names

[klimashkin]

camelCase option adds new props to style object, not replaces original ones.

It causes dirt when used with https://github.com/javivelasco/react-css-themr.

For instance, if I have .back-button {...} class, css-loader with camelCase returns

{
   back-button: '...',
   backButton: '...'
}

And if that style object is passed to react-css-themr as theme={styles} themeNamespace='back', it transforms it to

{
   -button: '...',
   button: '...'
}

It doesn't make any sense. Is there any reasons why original class name is saved by css-loader?

[timse]

this is most likely to keep being backword compatible etc.

why dont you just clean up the object before passing it along?

Object.keys(styles)
    .filter(style => style.indexOf('-') === -1)
    .reduce((cleanStyles, key) => {
        cleanStyles[key] = styles[key];
        return cleanStyles;
    }, {});

[klimashkin]

@timse In thousand components? : )

[timse]

im sure you find a better way :)
but isn't it dangerous anyways to rely on two independent systems to provide correct data for each others api?
you would probably want to have some intermediate step between those two in case one of them changes its api anyways no?

[michael-ciniawsky]

Will be fixed by #420

[joscha]

actually, will be fixed by #440 , #420 only removes the duplicate keys (cc @michael-ciniawsky )

[michael-ciniawsky]

@joscha Alright 🤣 all my hopes are shattered