fix: use `btoa` instead `Buffer` #501

alexander-akait · 2017-04-20T10:59:15Z

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

yes

If relevant, did you update the README?

not required

Summary

#454

Does this PR introduce a breaking change?

no

Other information

not required

codecov · 2017-04-20T11:01:22Z

Codecov Report

Merging #501 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage    98.3%   98.59%   +0.28%     
==========================================
  Files          10       10              
  Lines         355      355              
  Branches       80       80              
==========================================
+ Hits          349      350       +1     
+ Misses          6        5       -1

Impacted Files	Coverage Δ
lib/css-base.js	`97.5% <100%> (+2.5%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee2fc6...8b6593a. Read the comment docs.

michael-ciniawsky

Thy very much 😛

michael-ciniawsky · 2017-04-20T11:40:31Z

Fixes #454

alexander-akait · 2017-04-20T11:40:45Z

@michael-ciniawsky i think to version 1 we should close all bug issues 😄

alexander-akait · 2017-04-20T11:42:12Z

@michael-ciniawsky and be good release one patch version before v1 it is allow catch all regression errors, if of course they will be 😄

* master: fix: case insensitivity of @import (webpack-contrib#514) chore: update comment (webpack-contrib#515) docs(README): improve importLoaders section and example (webpack-contrib#512) docs(README): fix link (webpack-contrib#508) docs(README): fix typo in example (webpack-contrib#507) docs(README): fix typo in maintainers link (webpack-contrib#505) fix: imported variables are replaced in exports if followed by a comma (webpack-contrib#504) docs(README): standardize (webpack-contrib#503) test: `charset` directive (webpack-contrib#502) fix: url with a trailing space is now handled correctly (webpack-contrib#494) fix: use `btoa` instead `Buffer` (webpack-contrib#501) test: add test for escaped characters (webpack-contrib#493) test: add tests for encoded svg data uri (webpack-contrib#492) test: add tests when css contain data uri and source maps are enabled (webpack-contrib#491) fix: loader now correctly handles `url` with space(s) (webpack-contrib#495)

webdiscus · 2022-02-21T14:33:48Z

test/cssBaseTest.js

@@ -46,4 +64,17 @@ describe("css-base", function() {
 		}]);
 		m.toString().should.be.eql("body { a: 1; }\n/*# sourceURL=webpack://./path/to/test.scss */\n/*# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJmaWxlIjoidGVzdC5zY3NzIiwic291cmNlcyI6WyIuL3BhdGgvdG8vdGVzdC5zY3NzIl0sIm1hcHBpbmdzIjoiQUFBQTsiLCJzb3VyY2VSb290Ijoid2VicGFjazovLyJ9 */");
 	});
+	it("should toString without source mapping if btoa not avalibale", function() {


Why CSS should be extracted without source mapping if btoa not avalibale?
This is BREAKING CHANGE. In node <= 14 the CSS has not the inline source map.
If btoa not avalibale then shoul be used the Buffer.from(string).toString('base64') instead of btoa(string).

You can't use Buffer.from in browser

ok, I understand.

P.S: I use the css-loader runtime in a webpack plugin to generate inline source-map. In node 16 it works, but not in older node.

Because it was not design for this, you can send a PR and improve it

alexander-akait · 2022-02-21T14:47:00Z

lib/css-base.js

@@ -54,7 +54,7 @@ function cssWithMappingToString(item, useSourceMap) {
 		return content;
 	}

-	if (useSourceMap) {
+	if (useSourceMap && typeof btoa === 'function') {


You can't use Buffer.from in browser

Fixed: use btoa instead Buffer.

8b6593a

michael-ciniawsky approved these changes Apr 20, 2017

View reviewed changes

michael-ciniawsky changed the title ~~Fixed: use btoa instead Buffer.~~ fix: use btoa instead Buffer Apr 20, 2017

michael-ciniawsky self-assigned this Apr 20, 2017

michael-ciniawsky added pr: bugfix labels Apr 20, 2017

michael-ciniawsky merged commit fbb0714 into webpack-contrib:master Apr 20, 2017

alexander-akait deleted the issue-454 branch April 20, 2017 11:41

michael-ciniawsky mentioned this pull request Apr 20, 2017

Unnecessary Buffer polyfill when source maps are disabled #454

Closed

webdiscus reviewed Feb 21, 2022

View reviewed changes

alexander-akait commented Feb 21, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use `btoa` instead `Buffer` #501

fix: use `btoa` instead `Buffer` #501

alexander-akait commented Apr 20, 2017

codecov bot commented Apr 20, 2017 •

edited

Loading

michael-ciniawsky left a comment

michael-ciniawsky commented Apr 20, 2017

alexander-akait commented Apr 20, 2017

alexander-akait commented Apr 20, 2017

webdiscus Feb 21, 2022

alexander-akait Feb 21, 2022

webdiscus Feb 21, 2022

alexander-akait Feb 21, 2022

alexander-akait Feb 21, 2022

fix: use btoa instead Buffer #501

fix: use btoa instead Buffer #501

Conversation

alexander-akait commented Apr 20, 2017

codecov bot commented Apr 20, 2017 • edited Loading

Codecov Report

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky commented Apr 20, 2017

alexander-akait commented Apr 20, 2017

alexander-akait commented Apr 20, 2017

webdiscus Feb 21, 2022

Choose a reason for hiding this comment

alexander-akait Feb 21, 2022

Choose a reason for hiding this comment

webdiscus Feb 21, 2022

Choose a reason for hiding this comment

alexander-akait Feb 21, 2022

Choose a reason for hiding this comment

alexander-akait Feb 21, 2022

Choose a reason for hiding this comment

fix: use `btoa` instead `Buffer` #501

fix: use `btoa` instead `Buffer` #501

codecov bot commented Apr 20, 2017 •

edited

Loading