Avoid creating a new array inside doResolve. #427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor optimization that avoids allocating immediately dereferenced arrays when creating a new stack inside
doResolve
. In the build that I'm testing against, this is called >750k times, which means that we're allocating ~32mb of array data to the heap that's then spent in GC.It's hard to find optimizations in webpack's codebase, but from my debugging we're spending more time in GC than in any other function.
Here's a jsperf comparing these two ways of creating a one item set:
https://jsperf.app/vureri
And a screenshot of the output for me: