Skip to content

fix: js exception when reloading async chunk (#444) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: js exception when reloading async chunk (#444) #531

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef0374
fix: js exception when reloading async chunk (#444)
Rulexec May 22, 2020
f7e1963
test: hmr with non-file script in the end of page
Rulexec May 28, 2020
e39f104
Merge branch 'master' into hmr-js-exception
Rulexec Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/hmr/hotModuleReplacement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ function getReloadUrl(href, src) {
}

function reloadStyle(src) {
if (!src) {
return false;
}

const elements = document.querySelectorAll('link');
let loaded = false;

Expand Down