Update ferros/buffer to version 5

[venik]

Hi,

Sorry previous PR #67 contained wrong email. Is it possible to update ferros/buffer to version 5? Problem is that versions 4.X refers to global

Buffer.TYPED_ARRAY_SUPPORT = global.TYPED_ARRAY_SUPPORT !== undefined
  ? global.TYPED_ARRAY_SUPPORT
  : typedArraySupport()

which leads to #60 and #31

this patch has fixed this problem and version 5.X works just fine.

We used shrinkwrap to work it around, but would be better to have updated version of the node-libs-browser (npm-shrinkwrap.json):

{
  "dependencies": {
    "webpack": {
      "version": "3.3.0",
      "dependencies": {
        "node-libs-browser": {
          "version": "2.0.0",
          "dependencies": {
            "buffer": {
              "version": "5.0.7"
            }
          }
        }
      }
    }
  }
}

Thanks in advance!

[jsf-clabot]

All committers have signed the CLA.

[jhnns]

This is a breaking change, see feross/buffer@5daca86#commitcomment-19698936. We will pull this in with the next major version bump. Users that still need to support IE9 and IE10 can use a polyfill.

[venik]

@jhnns thx for the reply!

[blikblum]

IMO this is the right time to upgrade buffer.

Currently IE9 has a market share of 0.12% and IE10 0.11% (see https://caniuse.com/usage-table)

Within six month or so, when next webpack, browserify versions are released, these browsers will be even more irrelevant giving the trend

Postponing the upgrade can loose the opportunity to be shipped in bundlers next releases

[igrek8]

Buffer v4 fails at simple case Buffer.alloc(1, !!true), but works in any nodejs env. I think it is time to move forward and update the dependency

[blikblum]

Bump. This is the time to upgrade

[flipflopsimsommer]

any plans when this will be merged?

[mvasilkov]

Hi, can we please integrate this?

[sokra]

This library is deprecated and won't accept Pull Requests that include Breaking Changes or new Features. Only bugfixes are accepted.

We can't add a breaking change to webpack 4.

webpack 5 will no longer use node-libs-browser, but allows you to use any buffer version.