refactor: replace clone-deep with smaller klona #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klona has no dependencies and the package is smaller. https://packagephobia.com/result?p=klona https://packagephobia.com/result?p=clone-deep
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 4 4
Lines 191 191
Branches 63 63
=======================================
Hits 187 187
Misses 4 4
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jul 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good idea, I will migrate on klona in other loaders/plugins where we use clone-deep, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation
Bloated node_modules with ton of packages.
Klona has no dependencies and the package is smaller.
https://packagephobia.com/result?p=klona
https://packagephobia.com/result?p=clone-deep
Breaking Changes
No
Additional Info
No