feat: Set custom attributes for tag in url mode #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
approved these changes
Mar 22, 2017
Member
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
@KonstantinKai Thx, please add/update docs 😛
michael-ciniawsky
added
type: Feature
pr_action: Review
type: Test
pr: docs
and removed
type: Test
labels
bebraw
approved these changes
Mar 22, 2017
michael-ciniawsky
approved these changes
Mar 22, 2017
joshwiens
approved these changes
Mar 22, 2017
joshwiens
changed the title
Member
|
Released and published as https://github.com/webpack-contrib/style-loader/blob/v0.16.0/CHANGELOG.md#change-log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature: add ability to set custom attributes for tag in url mode.
Did you add tests for your changes?
Yes, I added tests for this PR.
If relevant, did you update the README?
No
Motivation
This PR related to 995f3de. In that release introduced ability to add custom attributes to tag only for default/usable mode, but not for url mode.
My PR covered that functionality.
Does this PR introduce a breaking change?
No