Wrong Stylelint version, not respecting peer dependency (using Yarn)

[alexilyaev]

This might be a Yarn issue...

In package.json:

"stylelint": "7.12.0",
"stylelint-webpack-plugin": "0.8.0",

Installing using Yarn v0.27.5

Running npm ls stylelint:

├── stylelint@7.12.0 
└─┬ stylelint-webpack-plugin@0.8.0
  └── stylelint@7.11.0 

Error:

Error: Undefined rule selector-max-id
    at module.exports (/Users/alex/www/Node/Personal/dynamo-builder/node_modules/stylelint-webpack-plugin/node_modules/stylelint/lib/utils/configurationError.js:8:27)
    at Object.keys.forEach.ruleName (/Users/alex/www/Node/Personal/dynamo-builder/node_modules/stylelint-webpack-plugin/node_modules/stylelint/lib/augmentConfig.js:279:13)
    at Array.forEach (native)
    at normalizeAllRuleSettings (/Users/alex/www/Node/Personal/dynamo-builder/node_modules/stylelint-webpack-plugin/node_modules/stylelint/lib/augmentConfig.js:275:29)
    at augmentConfigBasic.then.then.then.then.augmentedConfig (/Users/alex/www/Node/Personal/dynamo-builder/node_modules/stylelint-webpack-plugin/node_modules/stylelint/lib/augmentConfig.js:84:12)

selector-max-id was added only in 7.12.0.
I'd expect stylelint-webpack-plugin to use the peer instead of installing it's own version of Stylelint.

Installing using npm v5.0.3

Works as expected.

Running npm ls stylelint:

├── stylelint@7.12.0 
└─┬ stylelint-webpack-plugin@0.8.0
  └── stylelint@7.12.0  deduped

[alexilyaev]

For now updated in yarn.lock the 7.11.0 version to 7.12.0 and ran yarn --force and it worked:

$ yarn list stylelint
yarn list v0.27.5
└─ stylelint@7.12.0

[JaKXz]

Sounds like a yarn issue, though now that I think about it, since stylelint is a direct dependency of this package, it doesn't necessarily need to be listed in peerDeps. I'd welcome a PR to change this, but I'm okay with the status quo. That probably won't help with this issue directly, but it would be a good cleanup item.

[alexilyaev]

I agree it's a Yarn issue.

But, Ideally, I think it would be a peer dep only.
Otherwise we will inevitably run into a misconfiguration at some version bump that our ^ version does not match compared to what the user installed.

So, it would be best if we just use what what the user installed.

I'm developing stylelint-find-rules, and I used peerDependencies, works well.

[JaKXz]

I think I could make stylelint a dev dependency, which would solve this problem. Now that we've upgraded to stylelint v8, this is probably a good time to do it.

[JaKXz]

@alexilyaev if you could try v0.9.0, it should solve your problem [while upgrading to stylelint v8]. Feel free to close this issue or we can continue the discussion if things aren't working for you.

[reeddunkle]

Since stylint v8 is a breaking, major version update, would you consider changing v0.9.0 to v1.0.0 to reflect that it is a major, breaking version update also?

In our package.json, we have "stylelint-webpack-plugin": "^0.7.0". It took me a while to trace the breaking change back to here. For now I've removed the carrot (^).

I can open an issue if that's preferable, but I know people have different opinions about versioning, so I thought a comment was a better place to start.

UPDATE:
It's working now, even with the carrot. It's only installing v0.7.1, which might be what npm was meant to be doing. I'm not sure why it was installing v0.9.0 before.

Feel free to delete this comment. It seems the error has been on my end this whole time. Sorry.

[nickgcattaneo]

@reeddunkle when no major is specified, npm shifts the logic right, so minor becomes major and thus as you noted in your update the caret shouldn't upgrade you to 0.9.0. That being said, if the versioning was 1.9.0 and you specified a caret in front of 1.7.1, that would pull in 1.9.0 (e.g. highest 1.x).

[reeddunkle]

@nickgcattaneo I didn't know that. Thanks!

[JaKXz]

@reeddunkle that's a fair question, I had the same one about semver :) thanks @nickgcattaneo for chiming in. I'm going to close this for now and a new discussion can start if required in a new issue.