Duplicated warnings in console when quiet flag is set to false

[sergesemashko]

I noticed that warrnings are duplicated when quiet flag is set to false - http://take.ms/GQb4g.
I think, this line is the reason

[bellizio]

I've just encountered this issue as well. Here is a screenshot:

Setting quiet: true removes the first output (in orange) and only shows the second output (in pink).

[JaKXz]

@bellizio so if I understand correctly, we only want to see the second output (pink) if we have quiet set to anything but false? I have achieved this in #60, but I'm thinking that maybe this is not the behaviour that was intended for the quiet flag. I believe it's meant to suppress ALL of stylelint's output in the webpack console, would you guys agree? [In which case @sergesemashko your suggestion makes more sense.]

[JaKXz]

@sergesemashko @bellizio this behaviour was brought back to this state in #51. If you have a few minutes to try stylelint-webpack-plugin#master let me know if it works for you, and if it doesn't, feel free to open a PR :)

[rfgamaral]

@JaKXz I'm also having this issue and I tried the master branch but I don't think the behavior is quite there... I have failOnError: false (which is the default), yet the build fails when we have CSS errors.

Given the screenshot above, the fix would be to remove the pink output (error, failing the build), not the orange one (just warnings, build is successful).

EDIT: Ok, it didn't actually fail the build... I was using webpack-dev-server, changing .css files around and the server was always working. Given this, my suggestion is to change this to warnings (the orange one) and only show the errors (the pink ones), plus failing the build, with failOnError: true. I also agree that quiet: true should suppress ALL errors/warnings. My 2 cents.

[sergesemashko]

Duplicates are fixed in master branch. @JaKXz, I would agree that quiet: true should suppress any messages (both warnings and errors) to console.

[bellizio]

@JaKXz I think the first output (orange) should be removed. I tested the master branch and can confirm the duplicate outputs are gone now as a result of the latest merge.

Also, I think it's worth noting that the severity of all stylelint rules is "error" by default as per the docs. That being said, the first output (orange) in the screenshot I initially posted are errors, not warnings.

As a test, I changed the severity of my indentation rule (on the master branch) to "warning". The output now looks like this:

However, if there are "errors" in addition to "warnings", the output is this:

Given that, I think the most recent changes to the eliminate the duplicate outputs are appropriate and make the most sense. But I'm not sure that the output when there errors and warnings is optimal.

Lastly, I am also in agreement that quiet: true should suppress both warnings and/or errors if there are any. Perhaps that should be addressed in a separate issue, though.

What does everyone think?

[cwonrails]

Has anyone found a solution / have any input regarding @bellizio's comment in #61 (comment)?

[JaKXz]

Is this still an issue for folks with v0.7?

[DorianGrey]

It is.
Atm., the linter results are manually logged here, but they are also added as warnings or errors to the compilation results here. Thus, they appear twice in case quiet is set to false.

When setting quiet to true or just leaving it out, the results are only added in the after-emit hook, which I'd expect to happen.

To be honest, I'm not sure if the quiet option is useful anyway - it does not make sense to add a linter to the process, but suppress its output.

[nass600]

Any news about this? It is still happening in 0.10.1

[stevenleija]

Any updates on this? I'm working on our build scripts and would like to suppress the warning notifications during a production build and this appears to be the thread addressing this feature.