feat: (WIP) started conversion of tapable to TypeScript #13
Conversation
|
not ideal, but the API could change to be Promise-based instead of callback based. applyPluginsAsyncSeries(name: string, ...args: Array<any>): PromiseThat's probably an entire bikeshedding session on its own though... /ducks out before someone throws a shoe |
|
I mean promises would be really cool is just that it would be a ginourmous breaking change. |
| return current; | ||
| } | ||
|
|
||
| protected applyPluginsWaterfall0(name: string, init: any) { |
There was a problem hiding this comment.
the old style that naming function with number is very confusing. better to be self-explained.
There was a problem hiding this comment.
So changing the actual name of the function would require a huge changes to webpack/core, but once I've gotten this fully migrated, I can add a comment to explain how some are ussing call and some use apply thus the strange name.
|
promise is good. Breaking change is inevitable when introducing awesome feature in most of time. As webpack 2 will be incompatible with webpack 1. Introducing breaking change would affect webpack 2 basically |
|
One thing worth mentioned is documentation. Especially, the As webpack grows so popular, the core concept is one of the most important thing to be clarified, for further improvement. |
|
I agree with you. Most users don't even understand Tapable or the entire webpack internals. It certainly is an opprotunity to fix that through code quality. |
|
Types are on hold at the moment. Would require potentially a design change especially with delegation. |
Still very work in progress. One thing to note, is that TS doesn't support
..argsthat are not the final parameter. There is an ugly workaround that would have to be considered. microsoft/TypeScript#7347