Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update topic heading as per locked status #18

Merged
merged 3 commits into from
Jan 10, 2020
Merged

chore: update topic heading as per locked status #18

merged 3 commits into from
Jan 10, 2020

Conversation

anshumanv
Copy link
Member

@jsf-clabot
Copy link

jsf-clabot commented Jan 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@anshumanv anshumanv mentioned this pull request Jan 2, 2020
Closed
montogeek
montogeek reviewed Jan 2, 2020
View reviewed changes
src/components/topic/topic.jsx Outdated
}
});
}
constructor(props) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert formatting changes, it is unclear what was changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL. 👍

EugeneHlushko
EugeneHlushko requested changes Jan 10, 2020
View reviewed changes
src/components/topic/topic.jsx Outdated Show resolved Hide resolved
@EugeneHlushko EugeneHlushko merged commit cc4337b into webpack:master Jan 10, 2020
@EugeneHlushko
Copy link
Member

Thanks!

@anshumanv
Copy link
Member Author

Cool, thanks for the review!

@anshumanv anshumanv deleted the 3446 branch January 10, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshumanv @jsf-clabot @EugeneHlushko @montogeek