Merge pull request #33 from nkzawa/fix/remove-event

Fix remove event is not emitted
webpack · Dec 14, 2016 · 16b2a0e · 16b2a0e
2 parents d9b0dbc + 0232e01
commit 16b2a0e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/DirectoryWatcher.js b/lib/DirectoryWatcher.js
@@ -83,7 +83,8 @@ DirectoryWatcher.prototype.setFileTime = function setFileTime(filePath, mtime, i
 	this.files[filePath] = [initial ? Math.min(now, mtime) : now, mtime];
 
 	// we add the fs accurency to reach the maximum possible mtime
-	mtime = mtime + FS_ACCURENCY;
+	if(mtime)
+		mtime = mtime + FS_ACCURENCY;
 
 	if(!old) {
 		if(mtime) {

diff --git a/test/DirectoryWatcher.test.js b/test/DirectoryWatcher.test.js
@@ -143,4 +143,18 @@ describe("DirectoryWatcher", function() {
 			});
 		});
 	});
+
+	it("should detect a file removal", function(done) {
+		testHelper.file("a");
+		var d = new DirectoryWatcher(fixtures, {});
+		var a = d.watch(path.join(fixtures, "a"));
+		a.on("remove", function(mtime) {
+			(typeof mtime === 'undefined').should.be.true;
+			a.close();
+			done();
+		});
+		testHelper.tick(function() {
+			testHelper.remove("a");
+		});
+	});
 });