Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Config for only watching some of the events #82

Closed
meteorlxy opened this issue May 12, 2018 · 2 comments
Closed

[Feature request] Config for only watching some of the events #82

meteorlxy opened this issue May 12, 2018 · 2 comments

Comments

@meteorlxy
Copy link

meteorlxy commented May 12, 2018

Currently, we are watching all the events:

this.watcher.on("add", this.onFileAdded.bind(this));
this.watcher.on("addDir", this.onDirectoryAdded.bind(this));
this.watcher.on("change", this.onChange.bind(this));
this.watcher.on("unlink", this.onFileUnlinked.bind(this));
this.watcher.on("unlinkDir", this.onDirectoryUnlinked.bind(this));
this.watcher.on("error", this.onWatcherError.bind(this));

In our case (vuejs/vuepress#351), we only want webpack to watch change events, and other events will be handled by ourselves.

@alexander-akait
Copy link
Member

@meteorlxy PR welcome 👍

@meteorlxy
Copy link
Author

@evilebottnawi

I've created a PR #83 .

Your advice would help a lot.

@sokra sokra closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants