feat(migrate): CCP to SCP - fix tests

webpack · Aug 7, 2018 · 846cc5a · 846cc5a
1 parent 6329aaa
commit 846cc5a
Show file tree

Hide file tree

Showing 11 changed files with 117 additions and 118 deletions.
diff --git a/packages/migrate/commonsChunkPlugin/__snapshots__/commonsChunkPlugin.test.js.snap b/packages/migrate/commonsChunkPlugin/__snapshots__/commonsChunkPlugin.test.js.snap
@@ -8,15 +8,15 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-0" da
 
             cacheGroups: {
                 common: {
+                    name: 'common',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'common'
+                    enforce: true
                 },
 
                 vendor: {
+                    name: 'vendor',
                     chunks: 'initial',
                     enforce: true,
-                    name: 'vendor',
                     test: '/node_modules/'
                 }
             }
@@ -32,15 +32,15 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-1" da
         splitChunks: {
             cacheGroups: {
                 common: {
+                    name: 'common',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'common'
+                    enforce: true
                 },
 
                 vendor: {
+                    name: 'vendor',
                     chunks: 'initial',
                     enforce: true,
-                    name: 'vendor',
                     test: '/node_modules/'
                 }
             }
@@ -56,9 +56,9 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-2" da
         splitChunks: {
             cacheGroups: {
                 vendor: {
+                    name: 'vendor',
                     chunks: 'initial',
                     enforce: true,
-                    name: 'vendor',
                     test: '/node_modules/'
                 }
             }
@@ -74,9 +74,9 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-3" da
         splitChunks: {
             cacheGroups: {
                 commons: {
+                    name: 'commons',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'commons'
+                    enforce: true
                 }
             }
         }
@@ -95,8 +95,6 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-4" da
 
             cacheGroups: {
                 main: {
-                    chunks: 'initial',
-                    enforce: true,
                     name: 'main'
                 }
             }
@@ -112,9 +110,9 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-5" da
         splitChunks: {
             cacheGroups: {
                 main: {
+                    name: 'main',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'main'
+                    enforce: true
                 }
             }
         },
@@ -131,15 +129,15 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-6" da
         splitChunks: {
             cacheGroups: {
                 main: {
+                    name: 'main',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'main'
+                    enforce: true
                 },
 
                 name: {
+                    name: 'name',
                     chunks: 'initial',
                     enforce: true,
-                    name: 'name',
                     test: ({ resource }) => /node_modules/.test(resource),
 
                     test: ({ resource }) => {
@@ -178,15 +176,15 @@ exports[`commonsChunkPlugin transforms correctly using "commonsChunkPlugin-7" da
 
             cacheGroups: {
                 main: {
+                    name: 'main',
                     chunks: 'initial',
-                    enforce: true,
-                    name: 'main'
+                    enforce: true
                 },
 
                 vendor: {
+                    name: 'vendor',
                     chunks: 'initial',
                     enforce: true,
-                    name: 'vendor',
                     test: '/node_modules/'
                 }
             }

diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-0.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-0.input.js
@@ -1,8 +1,8 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
-            names: ["common", "vendor"],
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
+			names: ["common", "vendor"],
 			minChunks: 2
-        })
-    ]
+		})
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-1.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-1.input.js
@@ -1,7 +1,7 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
-            names: ["common", "vendor"]
-        })
-    ]
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
+			names: ["common", "vendor"]
+		})
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-2.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-2.input.js
@@ -1,7 +1,7 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
-            names: ["vendor"]
-        })
-    ]
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
+			names: ["vendor"]
+		})
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-3.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-3.input.js
@@ -1,8 +1,8 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
 			filename: "commons.js",
 			name: "commons"
 		})
-    ]
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-4.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-4.input.js
@@ -1,10 +1,10 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
 			name: "main",
-            async: true,
-            minSize: 0,
-            minChunks: 2
+			async: true,
+			minSize: 0,
+			minChunks: 2
 		})
-    ]
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-5.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-5.input.js
@@ -1,7 +1,7 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
 			names: ["main", "runtime"],
 		})
-    ]
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-6.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-6.input.js
@@ -1,6 +1,6 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
 			name: "main",
 			minChunks: ({ resource }) => /node_modules/.test(resource),
 			minChunks: ({ resource }) => {
@@ -22,5 +22,5 @@ module.export = {
 				}
 			}
 		})
-    ]
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-7.input.js b/packages/migrate/commonsChunkPlugin/__testfixtures__/commonsChunkPlugin-7.input.js
@@ -1,11 +1,8 @@
 module.export = {
-    plugins: [
-        new webpack.optimize.CommonsChunkPlugin({
+	plugins: [
+		new webpack.optimize.CommonsChunkPlugin({
 			names: ["main", "vendor"],
 			minChunks: Infinity,
-		}),
-		// new webpack.optimize.CommonsChunkPlugin({
-		// 	name: "vendor",
-		// }),
-    ]
+		})
+	]
 }
diff --git a/packages/migrate/commonsChunkPlugin/commonsChunkPlugin.test.js b/packages/migrate/commonsChunkPlugin/commonsChunkPlugin.test.js
@@ -6,7 +6,7 @@ defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-0");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-1");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-2");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-3");
-defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-4"); // todo fix async case
+defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-4");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-5");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-6");
 defineTest(__dirname, "commonsChunkPlugin", "commonsChunkPlugin-7");