Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languageSupport tests #1447

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Conversation

knagaitsev
Copy link
Contributor

What kind of change does this PR introduce?

tests

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

no
Summary

Added tests for languageSupport util

Does this PR introduce a breaking change?

No

Other information

@knagaitsev knagaitsev requested a review from a team as a code owner April 11, 2020 21:58
import language, { LangType, getBabelLoader, getTypescriptLoader } from '../../lib/utils/languageSupport';

describe('languageSupport', () => {
const getMockGenerator: any = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need fix that place

import language, { LangType, getBabelLoader, getTypescriptLoader } from '../../lib/utils/languageSupport';

describe('languageSupport', () => {
const getMockGenerator = (): any => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/сс @Loonride can you fix a warning?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evenstensberg
Copy link
Member

Could you rebase?

@webpack-bot
Copy link

@evilebottnawi Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants