Skip to content

fix: json flag, enable tests #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2020
Merged

fix: json flag, enable tests #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e24cd1
fix: json flag, enable tests
anshumanv Apr 14, 2020
c93774d
fix: json flag, enable tests
anshumanv Apr 14, 2020
a6c0818
fix: json flag, enable tests
anshumanv Apr 14, 2020
344145d
Merge branch 'next' into fix/json
evilebottnawi Apr 14, 2020
8fb585f
Merge branch 'next' into fix/json
rishabh3112 Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/webpack-cli/lib/groups/StatsGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ class StatsGroup extends GroupHelper {
this.opts.options.stats = this.args.stats;
}
}
if (this.args.json) {
this.opts.outputOptions.json = true;
}
}

run() {
Expand Down
26 changes: 9 additions & 17 deletions test/json/json.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,15 @@
'use strict';
const { join } = require('path');
const { run } = require('../utils/test-utils');
const webpack = require('webpack');

describe('json flag', () => {
it.skip('should match the snapshot of --json command', async () => {
const { stdout } = run(__dirname, [__dirname, '--json']);
const jsonstdout = JSON.parse(stdout);
const compiler = await webpack({
entry: './index.js',
output: {
filename: 'main.js',
path: join(__dirname, 'bin'),
},
});
compiler.run((err, stats) => {
expect(err).toBeFalsy();
const webpackStats = stats.toJson({ json: true });
expect(jsonstdout).toEqual(webpackStats);
});
it('should return valid json', () => {
const { stdout } = run(__dirname, ['--json']);

// helper function to check if JSON is valid
const parseJson = () => {
return JSON.parse(stdout);
};
// check the JSON is valid.
expect(parseJson).not.toThrow();
});
});