Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate build script #2318

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary

remove duplicate build script

Does this PR introduce a breaking change?
No

Other information
No

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2318 (a625bfa) into master (e44e855) will increase coverage by 19.35%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2318       +/-   ##
===========================================
+ Coverage   67.45%   86.80%   +19.35%     
===========================================
  Files          63       15       -48     
  Lines        2483      978     -1505     
  Branches      572      267      -305     
===========================================
- Hits         1675      849      -826     
+ Misses        808      129      -679     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 55.00% <0.00%> (ø)
packages/webpack-cli/lib/index.js 87.40% <0.00%> (-12.60%) ⬇️
packages/utils/src/copy-utils.ts
packages/generators/src/utils/languageSupport.ts
packages/migrate/src/loaders/loaders.ts
packages/generators/src/utils/styleSupport.ts
packages/utils/src/scaffold.ts
packages/migrate/src/resolve/resolve.ts
packages/utils/src/ast-utils.ts
...ate/src/loaderOptionsPlugin/loaderOptionsPlugin.ts
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3659c5e...a625bfa. Read the comment docs.

@alexander-akait
Copy link
Member

Something wrong with coverage 😕 But not related to this PR

@snitin315
Copy link
Member Author

Hmm, need to look into it.

@alexander-akait
Copy link
Member

I think we run it twice, so coverage was wrong

@alexander-akait
Copy link
Member

Let's merge

@alexander-akait alexander-akait merged commit 4e21053 into master Jan 6, 2021
@alexander-akait alexander-akait deleted the chore/build-script branch January 6, 2021 14:24
@rishabh3112
Copy link
Member

rishabh3112 commented Jan 7, 2021

This PR should not have been merged.

Something wrong with coverage confused But not related to this PR

Yup, we are not creating sourcemaps after this PR, which is required for testing ts files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants