Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to jest-circus #2747

Merged
merged 2 commits into from
Jun 3, 2021
Merged

chore: migrate to jest-circus #2747

merged 2 commits into from
Jun 3, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jun 2, 2021 •
edited
Loading

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary

Migrate to jest-circus which is the default test runner as of jest v27

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner June 2, 2021 00:45
@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited
Loading

Codecov Report

Merging #2747 (6654fd6) into master (23a2423) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2747   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          31       31           
  Lines        1634     1634           
  Branches      475      475           
=======================================
  Hits         1568     1568           
  Misses         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a2423...6654fd6. Read the comment docs.

anshumanv
anshumanv previously approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

@alexander-akait
Copy link
Member

Feel free to merge after CI will be green, thanks!

@snitin315 snitin315 requested a review from anshumanv June 2, 2021 13:59
@snitin315 snitin315 merged commit da68002 into master Jun 3, 2021
@snitin315 snitin315 deleted the jest-circus branch June 3, 2021 01:31
@JAREDARVIND
Copy link

JAREDARVIND commented Jun 3, 2021 •
edited
Loading

can you provide me a helium hotspot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshumanv anshumanv anshumanv approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snitin315 @alexander-akait @JAREDARVIND @anshumanv @webpack-bot