feat: new CLI options API for serve #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
previously approved these changes
Jun 3, 2021
packages/serve/src/index.ts
Outdated
|
|
||
| const options = | ||
| typeof devServer.getArguments === "function" | ||
| ? devServer.getArguments(webpack) |
Codecov Report
@@ Coverage Diff @@
## master #2754 +/- ##
==========================================
- Coverage 95.96% 94.25% -1.71%
==========================================
Files 31 31
Lines 1634 1672 +38
Branches 476 487 +11
==========================================
+ Hits 1568 1576 +8
- Misses 66 96 +30
Continue to review full report at Codecov.
|
|
Please ignore coverage, it will be fixed after update webpack-dev-server |
snitin315
previously approved these changes
Jun 4, 2021
anshumanv
previously approved these changes
Jun 4, 2021
evenstensberg
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Exist, but only work after merge webpack/webpack-dev-server#3325
If relevant, did you update the documentation?
No need
Summary
New API for CLI options
Does this PR introduce a breaking change?
No
Other information
I think we should refactor
serveand putstartDevServer.tsinindex.tsto avoid extrarequire(but it is not problem, becauserequireis cachable). Also we will avoid a lot offor/reduce/forEachafter #2626, but I want postpone it right now, focus on webpack-dev-server