Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node 16 to CI #2760

Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix: add node 16 to CI #2760

merged 1 commit into from
Jun 4, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

chore

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
NA

Summary
run tests on node 16

Does this PR introduce a breaking change?
shouldn't

Other information

@anshumanv
Copy link
Member Author

opened as draft to prevent accidental merge, lets watch CI

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #2760 (7cbc1d4) into master (f0b9274) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2760   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          31       31           
  Lines        1634     1634           
  Branches      475      476    +1     
=======================================
  Hits         1568     1568           
  Misses         66       66           
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 96.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b9274...7cbc1d4. Read the comment docs.

@anshumanv anshumanv marked this pull request as ready for review June 4, 2021 15:06
@anshumanv anshumanv requested a review from a team as a code owner June 4, 2021 15:06
@anshumanv
Copy link
Member Author

@alexander-akait yep it was node-sass, replacing with sass worked, thanks 👍

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, all is fine, feel free to merge after CI will be green

@anshumanv anshumanv merged commit 368778d into master Jun 4, 2021
@anshumanv anshumanv deleted the n16 branch June 4, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants