Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken serve with new CLI API #2770

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 7, 2021

What kind of change does this PR introduce?

bugfix, my mistake, check will be bad for webpack v4 and webpack-dev-server the next version

Did you add tests for your changes?

Latest, but we will have these test in webpack-dev-server

If relevant, did you update the documentation?

No need

Summary

Fix new CLI API

Does this PR introduce a breaking change?

No

Other information

I will do the new patch release after merge

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #2770 (8053b5e) into master (598008a) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2770      +/-   ##
==========================================
- Coverage   94.16%   94.10%   -0.06%     
==========================================
  Files          31       31              
  Lines        1679     1680       +1     
  Branches      488      489       +1     
==========================================
  Hits         1581     1581              
- Misses         98       99       +1     
Impacted Files Coverage Δ
packages/serve/src/index.ts 64.48% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060268b...8053b5e. Read the comment docs.

@alexander-akait alexander-akait merged commit 2d7ab35 into master Jun 7, 2021
@alexander-akait alexander-akait deleted the fix-broken-serve branch June 7, 2021 16:13
jamesgeorge007 pushed a commit to jamesgeorge007/webpack-cli that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants