Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use type for types #3832

Merged
merged 1 commit into from
Jun 4, 2023
Merged

refactor: use type for types #3832

merged 1 commit into from
Jun 4, 2023

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

Refactor - use type - better readability + better perf

Did you add tests for your changes?

No need

If relevant, did you update the documentation?

No need

Summary

Above

Does this PR introduce a breaking change?

No

Other information

Also extra class from types, because it is not a type

@alexander-akait alexander-akait requested a review from a team as a code owner June 4, 2023 01:16
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #3832 (d65ce98) into master (0931ab6) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3832   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          22       22           
  Lines        1673     1673           
  Branches      484      484           
=======================================
  Hits         1529     1529           
  Misses        144      144           
Impacted Files Coverage Δ
packages/configtest/src/index.ts 96.42% <ø> (ø)
packages/generators/src/handlers/default.ts 98.76% <ø> (ø)
packages/generators/src/handlers/react.ts 56.81% <ø> (ø)
packages/generators/src/index.ts 86.36% <ø> (ø)
packages/generators/src/loader-generator.ts 91.66% <ø> (ø)
packages/generators/src/plugin-generator.ts 100.00% <ø> (ø)
packages/generators/src/utils/helpers.ts 95.00% <ø> (ø)
packages/generators/src/utils/scaffold-utils.ts 100.00% <ø> (ø)
packages/info/src/index.ts 100.00% <ø> (ø)
packages/serve/src/index.ts 79.46% <ø> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0931ab6...d65ce98. Read the comment docs.

@alexander-akait alexander-akait merged commit beea1d1 into master Jun 4, 2023
@alexander-akait alexander-akait deleted the refactor-code branch June 4, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants