Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NamedModulesPlugin transformation #400

Closed
wants to merge 1 commit into from
Closed

Add NamedModulesPlugin transformation #400

wants to merge 1 commit into from

Conversation

bitpshr
Copy link
Member

@bitpshr bitpshr commented Apr 12, 2018

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
N/A

Summary
The migrate task didn't do anything with webpack.NamedModulesPlugin(). This PR adds a transformation for this plugin that removes it and safely sets optimizations: { namedPlugins: true }. Resolves #394.

Does this PR introduce a breaking change?
No

@bitpshr bitpshr changed the title ast(migrate): handle named modules Add NamedModulesPlugin transformation Apr 12, 2018
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico ematipico added this to the Vatican (v3) milestone Apr 12, 2018
@ematipico ematipico added the Semver: minor ⚙️ When delivering new features that don't break label Apr 12, 2018
@bitpshr
Copy link
Member Author

bitpshr commented Apr 12, 2018

Closing in favor of #399.

@bitpshr bitpshr closed this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: CI-ok PR: unreviewed Semver: minor ⚙️ When delivering new features that don't break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants