fix(bin, serve): force default package export, add serve default #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault ISSUES CLOSED: #572
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
evenstensberg
approved these changes
Apr 1, 2019
|
@webpack/cli-team PTAL, please do a local test against symlinked packages |
ematipico
approved these changes
Apr 2, 2019
dhruvdutt
approved these changes
Apr 2, 2019
sendilkumarn
approved these changes
Apr 2, 2019
misterdev
pushed a commit
to misterdev/webpack-cli
that referenced
this pull request
Apr 23, 2019
…pack#815) * fix(prompt-command, serve): force default package export, add serve default ISSUES CLOSED: webpack#572 * misc(serve): remove unnecessary exports, update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #572
What kind of change does this PR introduce?
This PR introduces a bugfix for the serve package to export a default function, and a more useful error message when a package does not export a default function.
Did you add tests for your changes?
No, I could not seem to find any tests relating to the packages, eg. serve, init. If you would like me to write tests I can, I might just need some guidance.
If relevant, did you update the documentation?
No
Summary
I ran into this issue: #589 while trying
webpack-cli serve. The reason for the issue is thatservedoes not export a default function. There was a PR earlier about this that never got finished #589.servestill has problems, but I think those should be addressed in a separate PR.Does this PR introduce a breaking change?
The changes in serve are not breaking, but the changes in bin are breaking for serve if you do not consider the changes I made. I'm not exactly sure how the npm publishing process works for these multiple packages. If everything is published at the same time, there is no problem, and if serve is published before the bin, there is no problem. In any case, serve seems to still have other problems with the current webpack-cli version outside of this.
Other information