-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(init-generator) cli improvements & refactor #817
misc(init-generator) cli improvements & refactor #817
Conversation
351bed6
to
c4c7fce
Compare
Ok, I'm happy about the work so far, I would appreciate to also receive feedback on further works; I see Would be desirable to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions and questions
I would really love to have typescript in this enhancement of the |
Do you want to try to move promises to |
Yes, what do you think about that? |
It's a good opportunity doing it now as you're working on revamping the whole generator :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some suggestions.
packages/webpack-scaffold/__tests__/__snapshots__/index.test.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few reviews.
PS: @evenstensberg changing prettier parser to |
@misterdev Could you make it so that tsc doesn't complain while having parser: babel? |
I don't have errors, but I remember I had that problem some times ago. |
@evenstensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
I didn't, had some old lockfiles, was fixed once I ran that. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice work!
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
What kind of change does this PR introduce?
Fixes some problems and adds new features
Did you add tests for your changes?
Yes, for
webpack-scaffold
Summary
Fixes: #884
Closes #814
Closes #788
From #814:
package.json
with a build script and a READMECLI output when selecting defaults:
Before
After
CLI output when multientry is chosen:
Before
After
Does this PR introduce a breaking change?
No