chore: migrate to github-actions #611

hiroppy · 2020-04-03T12:42:29Z

This PR contains a:

Motivation / Use-Case

Migrate from azure-pipelines to github-actions

Breaking Changes

no

Additional Info

codecov · 2020-04-03T13:11:45Z

Codecov Report

Merging #611 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           8        8           
  Lines         228      228           
  Branches       71       71           
=======================================
  Hits          226      226           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aebf98...5aebf98. Read the comment docs.

alexander-akait · 2020-04-03T14:36:11Z

That error is happening when tests are failed and watch not closed

alexander-akait

Maybe we should move on github actions, just idea

hiroppy · 2020-04-03T15:58:44Z

Actually I want to move to github CI:)

hiroppy · 2020-04-03T16:01:24Z

Anyway, I'll resolve this problem and then I'll refactor many things.

test/middleware.test.js

@@ -370,7 +370,7 @@ describe('middleware', () => {
      });
    });

-    describe('should work with difference requests', () => {
+    describe.skip('should work with difference requests', () => {


hiroppy · 2020-04-05T04:52:46Z

Added CODECOV_TOKEN to settings/secret.

hiroppy · 2020-04-05T05:13:11Z

windows CIs seem flaky, need to investigate.

hiroppy · 2020-04-05T12:27:55Z

I'll refactor tests after merging this pr.

hiroppy · 2020-04-05T12:57:53Z

CI is green.

hiroppy · 2020-04-05T12:58:43Z

I'll modify github's setting of branch settings.

alexander-akait · 2020-04-06T12:43:03Z

.github/workflows/tests.yml

+        uses: codecov/codecov-action@v1.0.6
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          file: '**/junit.xml'


Let's union two files in one, they are small and can be combined

alexander-akait · 2020-04-07T19:02:28Z

Seems segment fault appears after compiler = getCompiler(webpackMultiWarningConfig); in 3rd tests

alexander-akait · 2020-04-07T19:55:33Z

webpack@5 doesn't uses chokidar with fsevents and no problems, so I think the problem in chokidar or fsevents

alexander-akait · 2020-04-07T20:29:16Z

src/index.js

@@ -88,7 +88,8 @@ export default function wdm(compiler, options = {}) {
      // eslint-disable-next-line no-param-reassign
      callback = callback || noop;

-      context.watching.close(callback);
+      callback();
+      // context.watching.close(callback);


/cc @hiroppy The problem is here

Good, so can we resolve this problem?

I think bug in fsevents - fsevents/fsevents#314, need to fix it, probably will have to figure it out yourself, no problems with other os, today I will try to find a specific place of the problem

Maybe related - webpack/webpack#10037

Thank you for investigation!

hiroppy · 2020-04-08T11:55:28Z

.github/workflows/nodejs.yml

+      - next
+
+jobs:
+  #  lint:


Please uncomment lint job if possible

@hiroppy I will do it after we will fix the problem (before merge)

okay, thanks

alexander-akait · 2020-04-08T16:37:20Z

patch.js

+};
+
+`
+);


@hiroppy yes, problem(s) in fsevents, I patched chokidar does not use fsevents and tests passed.

Now macos users would probably see webpack consuming 1GB of memory and tons of CPU.

@paulmillr Firstly, this is not true, I can take measurements again and demonstrate them to you. Secondly, I don’t see a desire to correct a bug or help us find it, so I don’t see any other choice how to turn off fsevents. I am always open and aimed at improvements and fix bugs, but for some reason you react negatively to my attempts to find a compromise.

That's because we've already fixed the bug in chokidar 3 — and you should update. There is no "unwilingness", there is just desire to not do the same work twice.

Go ahead and remove fsevents. You'll notice some bug reports in a couple weeks.

@paulmillr Why are you so negative to me, have I really done something bad to you? All I'm trying to do is find the error and fix it.

hiroppy · 2020-04-09T13:40:39Z

CI looks good

alexander-akait · 2020-04-09T13:57:03Z

@hiroppy Let's merge 👍

hiroppy · 2020-04-09T13:58:16Z

@evilebottnawi Thank you for your investigation!

hiroppy · 2020-04-09T13:58:42Z

I'll copy to webapck-dev-server as well.

This comment has been minimized.

Sign in to view

hiroppy force-pushed the feature/modify-tests branch from c3816e6 to 69ebe09 Compare April 3, 2020 15:45

alexander-akait reviewed Apr 3, 2020

View reviewed changes

hiroppy commented Apr 3, 2020

View reviewed changes

test/middleware.test.js Outdated

@@ -370,7 +370,7 @@ describe('middleware', () => {

});

});

describe('should work with difference requests', () => {

describe.skip('should work with difference requests', () => {

This comment was marked as off-topic.

Sign in to view

hiroppy force-pushed the feature/modify-tests branch 2 times, most recently from 7653c9f to c362302 Compare April 3, 2020 16:47

hiroppy changed the title ~~Investigate tests~~ test(middleware): use setImmediate for MacOS CI Apr 3, 2020

hiroppy force-pushed the feature/modify-tests branch from c362302 to cbb48a0 Compare April 3, 2020 16:53

This comment has been minimized.

Sign in to view

hiroppy changed the title ~~test(middleware): use setImmediate for MacOS CI~~ chore: migrate to github-actions Apr 5, 2020

hiroppy force-pushed the feature/modify-tests branch from 44dc5d2 to 65bac2e Compare April 5, 2020 05:09

hiroppy force-pushed the feature/modify-tests branch 3 times, most recently from fc8136a to 1cd0835 Compare April 5, 2020 12:44

hiroppy marked this pull request as ready for review April 5, 2020 12:58

hiroppy requested a review from alexander-akait April 5, 2020 13:20

hiroppy mentioned this pull request Apr 6, 2020

refactor: refactor some code #614

Merged

6 tasks

alexander-akait reviewed Apr 6, 2020

View reviewed changes

ci: improve

cb4494b

alexander-akait added 5 commits April 7, 2020 22:06

ci: improve

34b0a27

ci: improve

35f68d3

ci: improve

39e537a

ci: improve

a8df486

ci: improve

e1165c7

alexander-akait mentioned this pull request Apr 7, 2020

segmentation fault on node 13.12 and macOS Catalina 10.15 (v1.2.12) fsevents/fsevents#314

Closed

alexander-akait added 2 commits April 7, 2020 23:20

ci: improve

68ab319

ci: improve

10cefa5

alexander-akait reviewed Apr 7, 2020

View reviewed changes

hiroppy commented Apr 8, 2020

View reviewed changes

ci: improve

01d7183

alexander-akait reviewed Apr 8, 2020

View reviewed changes

alexander-akait added 4 commits April 8, 2020 21:15

ci: improve

609eee4

ci: improve

28eaa15

ci: improve

f9f671c

ci: improve

a221ad9

alexander-akait closed this Apr 9, 2020

alexander-akait reopened this Apr 9, 2020

alexander-akait added 3 commits April 9, 2020 14:36

ci: improve

bf99c0e

ci: improve

174ba70

ci: improve

5aebf98

alexander-akait merged commit 43fa897 into master Apr 9, 2020

alexander-akait deleted the feature/modify-tests branch April 9, 2020 13:57

+                    - next
+              jobs:
+                #  lint:

+              };
+              `
+              );

chore: migrate to github-actions #611

chore: migrate to github-actions #611

Conversation

hiroppy commented Apr 3, 2020 • edited Loading

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Apr 3, 2020 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

alexander-akait commented Apr 3, 2020

This comment has been minimized.

This comment has been minimized.

alexander-akait left a comment

Choose a reason for hiding this comment

hiroppy commented Apr 3, 2020

hiroppy commented Apr 3, 2020

This comment was marked as off-topic.

This comment has been minimized.

hiroppy commented Apr 5, 2020

hiroppy commented Apr 5, 2020

hiroppy commented Apr 5, 2020

hiroppy commented Apr 5, 2020

hiroppy commented Apr 5, 2020

Choose a reason for hiding this comment

alexander-akait commented Apr 7, 2020

alexander-akait commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-akait Apr 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hiroppy commented Apr 9, 2020

alexander-akait commented Apr 9, 2020

hiroppy commented Apr 9, 2020

hiroppy commented Apr 9, 2020

hiroppy commented Apr 3, 2020 •

edited

Loading

codecov bot commented Apr 3, 2020 •

edited

Loading

alexander-akait Apr 8, 2020 •

edited

Loading