Skip to content

Commit

Permalink
fix: add link for historyApiFallback options (#3390)
Browse files Browse the repository at this point in the history
  • Loading branch information
snitin315 authored Jun 6, 2021
1 parent c0a0228 commit cef3d85
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lib/options.json
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,8 @@
"type": "boolean"
},
{
"type": "object"
"type": "object",
"description": "Options for `historyApiFallback`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
}
],
"description": "When using the HTML5 History API, the index.html page will likely have to be served in place of any 404 responses. https://webpack.js.org/configuration/dev-server/#devserverhistoryapifallback"
Expand Down
3 changes: 2 additions & 1 deletion test/__snapshots__/validate-options.test.js.snap.webpack4
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ exports[`options validate should throw an error on the "historyApiFallback" opti
Details:
* configuration.historyApiFallback should be a boolean.
* configuration.historyApiFallback should be an object:
object { … }"
object { … }
-> Options for \`historyApiFallback\`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
`;

exports[`options validate should throw an error on the "host" option with '' value 1`] = `
Expand Down
3 changes: 2 additions & 1 deletion test/__snapshots__/validate-options.test.js.snap.webpack5
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ exports[`options validate should throw an error on the "historyApiFallback" opti
Details:
* configuration.historyApiFallback should be a boolean.
* configuration.historyApiFallback should be an object:
object { … }"
object { … }
-> Options for \`historyApiFallback\`, description available at https://github.com/bripkens/connect-history-api-fallback#options"
`;

exports[`options validate should throw an error on the "host" option with '' value 1`] = `
Expand Down

0 comments on commit cef3d85

Please sign in to comment.