Crash on node 10.6.0 and up #1449

Ky6uk · 2018-07-30T12:17:23Z

Operating System: macOS 10.13.6
Node Version: 10.6.0, 10.7.0
NPM Version: 6.1.0
webpack Version: 4.16.3
webpack-dev-server Version: 3.1.5

This is a bug
This is a modification request

Webpack crashes sometimes in node 10.6.0 and up. Unfortunately I can't localize the problem, but I think this is relating to nodejs/node#21665.

The text was updated successfully, but these errors were encountered:

`spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. Fixes: webpack#1449 Fixes: nodejs/node#21665

blackshadev · 2018-08-17T10:38:26Z

@evilebottnawi this was one of the issues that moved me to webpack-serve since it completely broke webpack-dev-server with https for me.

`spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. Fixes: webpack#1449 Fixes: nodejs/node#21665

alexander-akait · 2018-08-30T11:14:38Z

Problem still exists?

Ky6uk · 2018-08-30T11:18:36Z

@evilebottnawi I am not sure, because I am using node v10.5.0 because of the bug. I will try to use the latest node from now. Let's see.

Ky6uk · 2018-08-31T14:23:27Z

Well, it looks fine for the last day with node v10.9.0. I think we can reopen this issue if something new will happen.

blackshadev · 2018-08-31T14:43:45Z

Good to hear. I will upgrade my setup next week and report back with the results.

…

On Fri, 31 Aug 2018, 16:23 Roman Nuritdinov, ***@***.***> wrote: Well, it looks fine for the last day with node v10.9.0. I think we can reopen this issue if something new will happen. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1449 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC11IAnAad6vq1A0jWHpqAZVnVSsSrt8ks5uWUbigaJpZM4VmTdG> .

blackshadev · 2018-09-05T09:26:41Z

@evilebottnawi Seems to work just fine. Thanks!

jrop · 2018-09-05T22:05:15Z

I am getting this in an app created with create-react-app under node 10.9.0

It seems to be intermittent

blackshadev · 2018-09-06T05:50:09Z

@jrop Which version of webpack-dev-server are you running. For me this is absolutely fixed in webpack-dev-server version 3.1.7

jrop · 2018-09-06T12:55:41Z

@blackshadev

macOS 10.13.6
webpack-dev-server 2.9.4

I created the app using create-react-app --scripts-version react-scripts-ts. As others have noted, rebooting the machine causes the issue to go away for a limited time. But then it comes right back. I have switched to using Node 8.11.4 and the issue has ceased to occur.

alexander-akait · 2018-09-06T12:58:00Z

@jrop you should update webpack-dev-server

jrop · 2018-09-06T13:07:14Z

@evilebottnawi I believe the responsible party to upgrading webpack-dev-server is the team maintaining react-scripts-ts, which is why I have resorted to using an older version of Node instead

WellspringCS · 2018-09-27T14:24:12Z

I may be confused, as I'm using Angular CLI which uses webpack-dev-server, but my version of webpack-dev-server in the root folder node_modules is 3.1.7, and I've specified that in my Angular package.json... and yet STILL I see this crash continuously. I'm going to take my version of node back to 10.5 and see what happens. (Currently it's 10.7)

WellspringCS · 2018-09-27T19:35:02Z

So... five hours later, and I've not seen the error yet. I still have the occasional "The expression evaluated to a falsy value" crash, but moving back to 10.5... I count it as a huge win.

For me, at least, webpack-dev-server 3.1.7 proved to be a false hope.

`spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. related issues: nodejs/node#21665 nodejs/node#21665 webpack#1449 expressjs/express#3388

cherry pick of webpack@e97d345 `spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. related issues: nodejs/node#21665 nodejs/node#21665 webpack#1449 expressjs/express#3388

cherry pick of webpack@e97d345 This commit is in webpack-dev-server v3 line, which requires webpack to be upgraded to >= 4.0.0 `spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. related issues: nodejs/node#21665 nodejs/node#21665 webpack#1449 expressjs/express#3388

cherry pick of webpack@e97d345 this issue was fixed is in webpack-dev-server v3 line, which requires webpack to be upgraded to >= 4.0.0. This commit cherry picks the fix to v2 branch (on top of v2.11.3) which does not require webpack to be upgraded to 4.0.0 `spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. related issues: nodejs/node#21665 nodejs/node#21665 webpack#1449 expressjs/express#3388

Ports fix for webpack#1449 to v2 branch cherry pick of webpack@e97d345 this issue was fixed in webpack-dev-server v3 line, which requires webpack to be upgraded to >= 4.0.0. This commit cherry picks the fix to v2 branch (on top of v2.11.3) which does not require webpack to be upgraded to 4.0.0 `spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. related issues: nodejs/node#21665 nodejs/node#21665 webpack#1449 expressjs/express#3388

Do not use `spdy` on Node 10 `spdy` is effectively unmaintained, and as a consequence of an implementation that extensively relies on Node’s non-public APIs, broken on Node 10 and above. In those cases, only https will be used for now. Once express supports Node's built-in HTTP/2 support, migrating over to that should be the best way to go. Fixes: webpack#1449 Fixes: nodejs/node#21665 https://github.com/webpack/webpack-dev-server/commit/e97d345ac370095a6e339b7997b939c88ef3e81b.patch

Backports fix for webpack#1449

See webpack/webpack-dev-server#1449

alexander-akait added type: bug priority: 3 (important) severity: 3 (broken) type: refactor labels Jul 31, 2018

addaleax mentioned this issue Aug 1, 2018

fix(Server): don't use spdy on node >= v10.0.0 #1451

Merged

5 tasks

lundibundi mentioned this issue Aug 14, 2018

Crash with "req.handle.writev is not a function" on Socket.Writable.uncork nodejs/node#21665

Closed

alexander-akait added priority: 1 (critical) and removed priority: 3 (important) labels Aug 17, 2018

blackshadev mentioned this issue Aug 17, 2018

revert(#77): incorrect check for existing socket clients webpack-contrib/webpack-hot-client#96

Open

2 tasks

Ky6uk closed this as completed Aug 31, 2018

ebenoist mentioned this issue Nov 20, 2018

Backports fix for #1449 reverbdotcom/webpack-dev-server#1

Merged

ebenoist pushed a commit to reverbdotcom/webpack-dev-server that referenced this issue Nov 20, 2018

Merge pull request #1 from reverbdotcom/erik/2-node-10

3f733f3

Backports fix for webpack#1449

josselinbuils added a commit to josselinbuils/reverse-proxy that referenced this issue Mar 2, 2019

Stop using spdy as it is not stable

27d015b

See webpack/webpack-dev-server#1449

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash on node 10.6.0 and up #1449

Crash on node 10.6.0 and up #1449

Ky6uk commented Jul 30, 2018 •

edited

Loading

blackshadev commented Aug 17, 2018

alexander-akait commented Aug 30, 2018

Ky6uk commented Aug 30, 2018

Ky6uk commented Aug 31, 2018

blackshadev commented Aug 31, 2018 via email

blackshadev commented Sep 5, 2018

jrop commented Sep 5, 2018 •

edited

Loading

blackshadev commented Sep 6, 2018

jrop commented Sep 6, 2018

alexander-akait commented Sep 6, 2018

jrop commented Sep 6, 2018

WellspringCS commented Sep 27, 2018

WellspringCS commented Sep 27, 2018

Crash on node 10.6.0 and up #1449

Crash on node 10.6.0 and up #1449

Comments

Ky6uk commented Jul 30, 2018 • edited Loading

blackshadev commented Aug 17, 2018

alexander-akait commented Aug 30, 2018

Ky6uk commented Aug 30, 2018

Ky6uk commented Aug 31, 2018

blackshadev commented Aug 31, 2018 via email

blackshadev commented Sep 5, 2018

jrop commented Sep 5, 2018 • edited Loading

blackshadev commented Sep 6, 2018

jrop commented Sep 6, 2018

alexander-akait commented Sep 6, 2018

jrop commented Sep 6, 2018

WellspringCS commented Sep 27, 2018

WellspringCS commented Sep 27, 2018

Ky6uk commented Jul 30, 2018 •

edited

Loading

jrop commented Sep 5, 2018 •

edited

Loading