[webpack-dev-server]: Setting Websocket Connection invoked twice

[rkovalov]

Bug report

Setting Websocket Connection invoked twice

Actual Behavior

invoked 2 request for setting websocket connection (see in Network Tab of DevTools )

Expected Behavior

invoked 1 request for setting websocket connection

How Do We Reproduce?

Repo for reproduce

1. yarn
2. yarn start

Please paste the results of npx webpack-cli info here, and mention other relevant information

[alexander-akait]

It was created by react-refresh-webpack-plugin, please reopen an issue, look at stack trace.

First connection:

  | WebSocketClient | @ | WebSocketClient.js:16
-- | -- | -- | --
  | initSocket | @ | socket.js:21
  | ./node_modules/webpack-dev-server/client/index.js?protocol=ws%3A&hostname=localhost&port=8080&pathname=%2Fws&logging=info&reconnect=10 | @ | index.js:273
  | options.factory | @ | react refresh:6
  | __webpack_require__ | @ | bootstrap:24
  | (anonymous) | @ | startup:5
  | (anonymous)

Second:

WebSocketClient | @ | WebSocketClient.js:16
-- | -- | --
  | initWDSSocket | @ | WDSSocket.js:23
  | initSocket | @ | ErrorOverlayEntry.js:83
  | executeWithRetryAndTimeout | @ | retry.js:9
  | runWithRetry | @ | retry.js:17
  | setupOverlay | @ | ErrorOverlayEntry.js:82
  | runWithPatchedUrl | @ | patchUrl.js:29
  | ./node_modules/@pmmmwh/react-refresh-webpack-plugin/client/ErrorOverlayEntry.js?sockHost=localhost&sockPort=8080&sockProtocol=http | @ | ErrorOverlayEntry.js:77
  | options.factory | @ | react refresh:6
  | __webpack_require__ | @ | bootstrap:24
  | (anonymous) | @ | startup:7
  | (anonymous)

look at | ./node_modules/@pmmmwh/react-refresh-webpack-plugin/client/ErrorOverlayEntry.js?sockHost=localhost&sockPort=8080&sockProtocol=http | @ | ErrorOverlayEntry.js:77

If you set:

new ReactRefreshPlugin({
  overlay: false
}),

no double connection

@pmmmwh can you provide more infromation

[alexander-akait]

@pmmmwh can we close it? is react refresh reuse our client?

[rkovalov]

@alexander-akait we can close it, Ive not check yet :) thanks

[pmmmwh]

Hi, this can be closed, we haven't updated the implementation yet but I'll do it soon.

[alexander-akait]

@pmmmwh Feel free to any feedback and PRs if you need to expose more