Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --allowed-hosts CLI option #1012

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Conversation

orteth01
Copy link
Contributor

@orteth01 orteth01 commented Jul 27, 2017

What kind of change does this PR introduce?
feature

Did you add or update the examples/?
no

Summary
adds the ability to set the allowedHosts option via the CLI

Does this PR introduce a breaking change?
no

Usage
I'm not sure what the best practice is for passing a list as a command line option. I opted for a comma delimited string. E.G.

webpack-dev-server --entry /entry/file --output-path /output/path --allowed-hosts host1.com,.host2.com

creates the option

allowedHosts: [
    'host1.com',
    '.host2.com'
] 

Please let me know if there is a better way to do this.

@codecov
Copy link

codecov bot commented Jul 27, 2017

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files           4        4           
  Lines         465      465           
  Branches      140      140           
=======================================
  Hits          336      336           
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72efaab...49f8052. Read the comment docs.

@orteth01 orteth01 force-pushed the allowed-hosts-cli branch from 9818677 to 49f8052 Compare July 27, 2017 18:33
@orteth01 orteth01 changed the title add allowedHosts CLI option add --allowed-hosts CLI option Jul 27, 2017
@shellscape
Copy link
Contributor

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants