Add feature to disable hotReloading with query string #1068
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 5 5
Lines 451 451
Branches 143 143
=======================================
Hits 330 330
Misses 121 121Continue to review full report at Codecov.
|
|
Any updates ? |
|
@edi9999 please do us a solid and wait about a week before pings 😄 I promise we see all activity here and will respond/comment as soon as possible. I'm currently preparing for hurricane irma and will be returning next week. |
|
Ok ! I hope everything will be OK for you |
client/index.js
Outdated
| @@ -22,6 +22,10 @@ function getCurrentScriptSource() { | |||
| } | |||
|
|
|||
| let urlParts; | |||
| let hotReloading = true; | |||
| if (typeof window !== 'undefined') { | |||
| hotReloading = window.location.search.indexOf('disableAutoReload') === -1; | |||
There was a problem hiding this comment.
not a fan of negative-options, meaning a positive value will result in the negative reassignment of another variable. let's also keep the variable names the same as the querystring parameter. so;
let hotReload = true;
...
const qs = window.location.search.toLowerCase();
hotReload = !qs.indexOf('hotreload=false');the code was trimmed for brevity, but those are the changes I'd like to see
What kind of change does this PR introduce?
Feature
Did you add or update the
examples/?No, but you could use any sample and use the queryParam :
?disableAutoreload=truetoSummary
See corresponding issue : #936
This option can be used if you want to use the same platform for developping and to run automated tests (the tests should not be impacted by a code change whenever they are running).
Does this PR introduce a breaking change?
No
Other information