Fixes issue #1064 by switching to a named logger #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add or update the
examples/
?no
Summary
This solves issue #1064
So far, the client JS of webpack-dev-server used the root logger and also changed the configuration of the root logger. This results in webpack overwriting the application's logging configuration.
The PR switches to a named logger, as suggested in the issue description.
Does this PR introduce a breaking change?
I don't think it could break an app.
However, if an application uses loglevel and expects webpack-dev-server to configure the root logger, it might have an different log level than expected.
The solution for the app would be to call loglevel's
setLevel
orsetDefaultLevel
(which is how you should do it anyway).